Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_a_pipeline.md #3213

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Update create_a_pipeline.md #3213

merged 4 commits into from
Nov 6, 2023

Conversation

pdave34
Copy link
Contributor

@pdave34 pdave34 commented Oct 21, 2023

typo:
--nodes=preprocess_shuttles_node needs to be specified

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

To fix a typo in spaceflight documentation

Development notes

Added relevant arguments in the example code

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

typo: 
--nodes=preprocess_shuttles_node needs to be specified

Signed-off-by: Pranav Dave <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdave34 ! I added one comment

docs/source/tutorial/create_a_pipeline.md Show resolved Hide resolved
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change, thanks!

@astrojuanlu astrojuanlu added the Community Issue/PR opened by the open-source community label Oct 22, 2023
@stichbury
Copy link
Contributor

I've decided to accept this suggested change with some minor modification, which I've committed to the branch. Hope it's all OK and thanks @pdave34 for your contribution! ⭐

@stichbury stichbury self-requested a review November 6, 2023 09:53
@stichbury stichbury enabled auto-merge (squash) November 6, 2023 09:53
@stichbury stichbury merged commit 2468b2d into kedro-org:main Nov 6, 2023
12 of 16 checks passed
deepyaman added a commit that referenced this pull request Nov 8, 2023
* Configure `ruff format`, use it instead of `black` (#3258)

* build: format code with `ruff format` over `black`

Signed-off-by: Deepyaman Datta <[email protected]>

* style(ruff-format): format code with `ruff format`

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>

* docs: fix typos (#3270)

Signed-off-by: Ajay Gonepuri <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>

* Update create_a_pipeline.md (#3213)

* Update create_a_pipeline.md

typo: 
--nodes=preprocess_shuttles_node needs to be specified

Signed-off-by: Pranav Dave <[email protected]>

* Use both node names

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Update create_a_pipeline.md

Signed-off-by: Jo Stichbury <[email protected]>

---------

Signed-off-by: Pranav Dave <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>

* Replace a `StopIteration` exception with for-else (#3273)

* Replace a `StopIteration` exception with for-else 

Signed-off-by: Nok Lam Chan <[email protected]>

* fix the logic

Signed-off-by: Nok <[email protected]>

* bug fix

Signed-off-by: Nok <[email protected]>

---------

Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok <[email protected]>

* Make `ruff format` happy

Signed-off-by: Deepyaman Datta <[email protected]>

* Make `ruff` happy

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Ajay Gonepuri <[email protected]>
Signed-off-by: Pranav Dave <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok <[email protected]>
Co-authored-by: Deepyaman Datta <[email protected]>
Co-authored-by: Ajay Gonepuri (GONAPCORP) <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Pranav Dave <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
JaynouOliver pushed a commit to JaynouOliver/kedro that referenced this pull request Nov 10, 2023
* Update create_a_pipeline.md

typo:
--nodes=preprocess_shuttles_node needs to be specified

Signed-off-by: Pranav Dave <[email protected]>

* Use both node names

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Update create_a_pipeline.md

Signed-off-by: Jo Stichbury <[email protected]>

---------

Signed-off-by: Pranav Dave <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Suvrakamal Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants