Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.1 #3421

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Release 0.19.1 #3421

merged 2 commits into from
Dec 13, 2023

Conversation

merelcht
Copy link
Member

Description

Minor release to solve dependency issue with kedro-telemetry and kedro 0.19.0.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht requested review from DimedS, lrcouto, SajidAlamQB and ankatiyar and removed request for stichbury and yetudada December 13, 2023 11:11
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take two

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏾

Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SajidAlamQB
Copy link
Contributor

I guess it needs starters to be released before the tests pass since starters 0.19.1 doesn't exist yet?

 'cookiecutter.exceptions.RepositoryCloneFailed: The 0.19.1 branch of '
 'repository https://github.com/kedro-org/kedro-starters.git could not found, '
 'have you made a typo?\n'

@DimedS
Copy link
Contributor

DimedS commented Dec 13, 2023

I guess it needs starters to be released before the tests pass since starters 0.19.1 doesn't exist yet?

 'cookiecutter.exceptions.RepositoryCloneFailed: The 0.19.1 branch of '
 'repository https://github.com/kedro-org/kedro-starters.git could not found, '
 'have you made a typo?\n'

or maybe modify that test?

@SajidAlamQB
Copy link
Contributor

or maybe modify that test?

Its test_invalid_tools_with_starter.

@AhdraMeraliQB
Copy link
Contributor

CC: @SajidAlamQB @DimedS

Made a PR to try and fix the test: #3422

@DimedS
Copy link
Contributor

DimedS commented Dec 13, 2023

or maybe modify that test?

Its test_invalid_tools_with_starter.

Yes, I added it, and idea was that we need to run kedro new with starter and config with tools or example_pipeline chosen, to throw an Error. But it can be any starter in that case, so maybe we just need to specify checkout there?

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take two

@DimedS
Copy link
Contributor

DimedS commented Dec 13, 2023

CC: @SajidAlamQB @DimedS

Made a PR to try and fix the test: #3422

Thank you! Looks perfect!

* Use template for starter

Signed-off-by: Ahdra Merali <[email protected]>

* Trigger CI

Signed-off-by: Ahdra Merali <[email protected]>

---------

Signed-off-by: Ahdra Merali <[email protected]>
@merelcht merelcht merged commit 99e194b into main Dec 13, 2023
36 checks passed
@merelcht merelcht deleted the release/0.19.1 branch December 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants