Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to get_pkg_version #3947

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

merelcht
Copy link
Member

Description

Closes #3789

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@merelcht merelcht marked this pull request as ready for review June 11, 2024 14:49
@merelcht merelcht self-assigned this Jun 11, 2024
Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht enabled auto-merge (squash) June 11, 2024 14:51
@merelcht merelcht merged commit 7963b61 into main Jun 12, 2024
41 checks passed
@merelcht merelcht deleted the deprecate-get-pkg-version branch June 12, 2024 13:24
bpmeek pushed a commit to bpmeek/kedro that referenced this pull request Jun 20, 2024
* Add deprecation warning to get_pkg_version

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: bpmeek <[email protected]>
bpmeek pushed a commit to bpmeek/kedro that referenced this pull request Jun 20, 2024
* Add deprecation warning to get_pkg_version

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: bpmeek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate (mark for future removal) get_pkg_version from the public API
3 participants