Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make credentials loading consistent between KedroContext._get_catalog() and catalog CLI #4165

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Make credentials loading consistent between KedroContext._get_catalog() and catalog CLI #4165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
810a538
Use _get_config_credentials() in catalog CLI
MigQ2 Sep 15, 2024
f1ac224
fix tests
MigQ2 Sep 15, 2024
9275250
fix test
MigQ2 Sep 15, 2024
407a390
Merge branch 'main' into fix/catalog-cli-credentials
MigQ2 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
## Bug fixes and other changes
* Fixed bug where using dataset factories breaks with `ThreadRunner`.
* Fixed template projects example tests.
* Made credentials loading consistent between `KedroContext._get_catalog()` and `resolve_patterns` so that both us
e `_get_config_credentials()`

## Breaking changes to the API
* Removed `ShelveStore` to address a security vulnerability.
Expand All @@ -21,6 +23,7 @@
* [Puneet](https://github.com/puneeter)
* [ethanknights](https://github.com/ethanknights)
* [Manezki](https://github.com/Manezki)
* [MigQ2](https://github.com/MigQ2)

# Release 0.19.8

Expand Down
2 changes: 1 addition & 1 deletion kedro/framework/cli/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None:
context = session.load_context()

catalog_config = context.config_loader["catalog"]
credentials_config = context.config_loader.get("credentials", None)
credentials_config = context._get_config_credentials()
data_catalog = DataCatalog.from_config(
catalog=catalog_config, credentials=credentials_config
)
Expand Down
1 change: 1 addition & 0 deletions tests/framework/cli/test_catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,7 @@ def test_catalog_resolve(
"catalog": fake_catalog_config,
"credentials": fake_credentials_config,
}
mocked_context._get_config_credentials.return_value = fake_credentials_config
mocked_context.catalog = DataCatalog.from_config(
catalog=fake_catalog_config, credentials=fake_credentials_config
)
Expand Down