Gracefully handle non-ASCII chars in dataset names 🌶️

[deepyaman]

Description

• Have simpler, yet more robust, handling around the "friendly" conversion of data set names
• It also helps avoid clashes like between datasets "perchè" and "perché" or even "jalapeño" and "jalape@o"
• On the last two points, if you do want special handling of accents, it should be more explicit/not here

Development notes

Dropped a Python 3.5 Windows relic allowing only ASCII files

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
• Added tests to cover my changes

Notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

• I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

• I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

• I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

[limdauto]

Nice catch! Could you mention this in the release note as well?

[921kiyo]

LGTM! It's also worth noting this in the release note :)

[deepyaman]

One more question: Would it make sense to move this into a function?

The reason I came across this was because 0.16.2 broke my code, so I'm handling it like so: deepyaman/kedro-accelerator@86897b0

Having it as a function would mean less likely changes for my (and similar) code, although I'm not sure this should change that frequently anyway.

[921kiyo]

Yeah, you can wrap datasets = {re.sub(r"\W+", "__", key): value for key, value in datasets.items()} as a private function, or leave it as it. Since it is one line, I'm happy with either.

[deepyaman]

Yeah, you can wrap datasets = {re.sub(r"\W+", "__", key): value for key, value in datasets.items()} as a private function, or leave it as it. Since it is one line, I'm happy with either.

Sorry, didn't do it last night as promised. I'll do it shortly