Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataset over data_set for all module names #855

Closed
wants to merge 6 commits into from

Conversation

deepyaman
Copy link
Member

Description

#533 (comment)

Development notes

Modules renamed, relevant tests updated

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@deepyaman deepyaman requested a review from idanov as a code owner August 15, 2021 22:36
@deepyaman deepyaman self-assigned this Aug 15, 2021
@deepyaman deepyaman changed the title Use "dataset" over "data_set" for all module names Use dataset over data_set for all module names Aug 15, 2021
@deepyaman deepyaman changed the base branch from master to develop August 18, 2021 01:14
@lorenabalan
Copy link
Contributor

Closing this in favour of duplicate PR on 2nd repo.

@lorenabalan lorenabalan deleted the chore/rename-modules branch August 19, 2021 14:24
austospumanto pushed a commit to austospumanto/kedro that referenced this pull request Aug 24, 2021
@astrojuanlu
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants