This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
libprotobuf-dev
to builder stage of Dockerfile.Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Docker release fails after 0.2.0(https://github.com/keep-starknet-strange/madara/actions/workflows/release.yml) with error message:
So even latest version of madara is 0.5.1(https://github.com/keep-starknet-strange/madara/tags), the docker image on release is only 0.2.0(https://github.com/keep-starknet-strange/madara/pkgs/container/madara).
This problem can be solved by adding
libprotobuf-dev
to builder.What is the new behavior?
Does this introduce a breaking change?
No
Other information
Referenced to grpc-ecosystem/grpc-gateway#422 (comment) this issue for solution.