Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

⬆️ upgrade substrate to polkadot-v0.9.43 #497

Merged
merged 10 commits into from
May 31, 2023

Conversation

d-roak
Copy link
Collaborator

@d-roak d-roak commented May 30, 2023

Upgrade substrate version to polkadot-v0.9.43.

Co-authored-by: @abdelhamidbakhta

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.15 ⚠️

Comparison is base (c49f2c8) 36.65% compared to head (ba90441) 35.51%.

❗ Current head ba90441 differs from pull request most recent head 9f2d95a. Consider uploading reports for the commit 9f2d95a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   36.65%   35.51%   -1.15%     
==========================================
  Files          63       63              
  Lines        6037     6411     +374     
  Branches     6037     6411     +374     
==========================================
+ Hits         2213     2277      +64     
- Misses       3304     3588     +284     
- Partials      520      546      +26     
Impacted Files Coverage Δ
crates/node/src/service.rs 0.00% <0.00%> (ø)
crates/node/src/starknet.rs 0.00% <0.00%> (ø)
crates/runtime/src/pallets.rs 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d-roak
Copy link
Collaborator Author

d-roak commented May 30, 2023

Breaking change from Substrate, no more ws options on the cli
paritytech/substrate#13384

@d-roak
Copy link
Collaborator Author

d-roak commented May 30, 2023

I fixed all ws occurrences for the tests
This PR also introduces a condition where the out-peers can't be set to 0

"--out-peers=0",

I commented that line in the tests, but would like some feedback on how you want to handle that. The error that appears is not friendly at all. But I think we can just stop specifying that param

Edit: The benchmark workflow also uses that param, which leads the workflow to infinitely looping

Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AbdelStark AbdelStark merged commit b65bc78 into keep-starknet-strange:main May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@d-roak d-roak deleted the abdelhamidbakhta/main branch June 6, 2023 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants