Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cosmos #29

Merged
merged 11 commits into from
Nov 22, 2019
Merged

Feature/cosmos #29

merged 11 commits into from
Nov 22, 2019

Conversation

ProofOfKeags
Copy link
Contributor

No description provided.

@keepkeyjon
Copy link
Contributor

This PR points at a different commit than https://github.com/keepkey/keepkey-firmware/pull/188/files

messages-stellar.proto Outdated Show resolved Hide resolved
messages-cosmos.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@keepkeyjon keepkeyjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits that we will need when we go to implement this in hdwallet, but LGTM otherwise.

messages-cosmos.proto Outdated Show resolved Hide resolved
messages-cosmos.proto Outdated Show resolved Hide resolved
messages-cosmos.proto Outdated Show resolved Hide resolved
@keepkeyjon keepkeyjon merged commit 143d73a into keepkey:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants