-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic sensors #109
Dynamic sensors #109
Conversation
…he values for the solar-strings can't be decoded
I did a small test on my inverter, all sensors seem to be available. Here the full output of the script:
|
Looking good! About the array based sensors. Do you have two strings of solar panels? Otherwise they wont give any values. |
I have both strings connected on my inverter, the value of
|
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 6 5 -1
Lines 428 241 -187
==========================================
- Hits 428 241 -187
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I found the issue and committed a fix. I am creating a file with test data for testing the code. Would you be able to share the response of your inverter for POST requests to |
Do you know of any users with a devices that requires the alternative jmespath queries? JMESPATH_VAL = "val"
JMESPATH_VAL_TAG = JMESPATH_VAL + "[0].tag"
JMESPATH_VAL_STR = "[?str==sum([`1`,`{}`])].val | [0]" Trying to build a file with test data and having this data would be really useful |
@FindusK , Could you share the response of your inverter for POST requests to /dyn/getAllOnlValues.json and /dyn/getAllParamValues.json so I can include them? I expect this gets the tests coverage to 100% |
@rklomp here is mine: pysma-debug.log |
Thanks @phdelodder and @FindusK! I have added both your data to the testfile and got a 100% coverage now |
This will get rid of device classes and use the
getAllOnlValues.json
andgetAllParamValues.json
to figure out which sensors are present on the device.