Make node-i2c compile with Node 4. #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v8::Buffer::New returns an instance of v8::MaybeLocal<> * an instance of v8::MaybeLocal<v8::Object> needs to be asked for the actual local by calling v8::MaybeLocal<v8::Object>::ToLocalChecked()
|
NaN (https://github.com/nodejs/nan) abstracts such native incompatabilities that are introduced with every new v8 version |
|
+1 to get a working solution merged! |
|
Thanks for this pr! Moving forward I'm looking to integrate NaN so these issues don't arise again. Unfortunately, using NaN requires almost a full re-write. |
|
@kelly: I would encourage you to merge the PR rather than waiting for the time to do a re-write for NaN. While it is a bit of a hack, when one uses your module because a dependency from npm, it will nearly always break those modules if they are running a currently supported version of node. |
|
May you try to submit to this fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by calling v8::MaybeLocalv8::Object::ToLocalChecked()