Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #119

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

MichaelDeBoey
Copy link
Collaborator

@MichaelDeBoey MichaelDeBoey commented Sep 4, 2021

ESLint v8.0.0 is released 🎉

Dependencies should be compatible with ESLint 8 too before we can merge this one:

devDependency compatibility with ESLint 8:


BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0

Closes #117

This branch is dependent on #122, #123, #124, #125 & #126

package.json Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Collaborator Author

@kentcdodds I've merged #122, #123, #124, #125 & #126 and added one last commit to support ESLint v8.x

@MichaelDeBoey MichaelDeBoey changed the base branch from main to alpha January 5, 2022 15:28
@kentcdodds
Copy link
Owner

Are we still waiting on testing-library/eslint-plugin-jest-dom#200?

@MichaelDeBoey
Copy link
Collaborator Author

@kentcdodds We only need to merge those other PRs in the alpha branch and afterwards this one's good to be merged.

Once that's done, we can merge alpha into main

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

BREAKING CHANGE: Requires ESLint@^8.0.0
@MichaelDeBoey MichaelDeBoey merged commit badba38 into kentcdodds:alpha Jan 7, 2022
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch January 7, 2022 00:37
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jan 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This PR is included in version 20.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This PR is included in version 20.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
3 participants