Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Upgrade to eslint 8.53.0 and prettier 2.8.8, fix lint and type errors #2607

Merged
merged 5 commits into from
Aug 20, 2024
Merged

[Chore] Upgrade to eslint 8.53.0 and prettier 2.8.8, fix lint and type errors #2607

merged 5 commits into from
Aug 20, 2024

Conversation

heshan0131
Copy link
Contributor

@heshan0131 heshan0131 commented Aug 16, 2024 •
edited
Loading

  • Run lint with autofix
  • Run prettier with autofix
  • Added @typescript-eslint
  • Still need to fix lots of types and turn on @typescript-eslint/no-explicit-any

@heshan0131
upgrade to eslint 8
c51fa65 
Signed-off-by: Shan He <[email protected]>
@heshan0131
fix lint
85e61e7 
Signed-off-by: Shan He <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit b3275b7
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66c42d0d4428cd00081667da
😎 Deploy Preview https://deploy-preview-2607--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@heshan0131 heshan0131 changed the title [Chore] Upgrade to eslint 8.53.0, fix lint and type errors [Chore] Upgrade to eslint 8.53.0 and prettier 2.8.8, fix lint and type errors Aug 16, 2024
@heshan0131 heshan0131 marked this pull request as ready for review August 17, 2024 20:06
ibgreen
ibgreen approved these changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@heshan0131
attempt to fix test.yml
716bf2c 
Signed-off-by: Shan He <[email protected]>
@heshan0131
fix test
b3275b7 
Signed-off-by: Shan He <[email protected]>
@heshan0131 heshan0131 merged commit affc5b6 into master Aug 20, 2024
12 checks passed
@heshan0131 heshan0131 deleted the 0809-fix-lint branch August 20, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@igorDykhta igorDykhta Awaiting requested review from igorDykhta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heshan0131 @ibgreen