Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] restore arc and line layers in non-geoarrow modes #2732

Merged
merged 5 commits into from
Nov 4, 2024
Merged

[fix] restore arc and line layers in non-geoarrow modes #2732

merged 5 commits into from
Nov 4, 2024

Conversation

igorDykhta
Copy link
Collaborator

For #2728

  • don't pass getSourcePosition & getTargetPosition as undefined to non-arrow layers

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit d3b732c
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/6729248eb7a07900084b8b13
😎 Deploy Preview https://deploy-preview-2732--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igorDykhta
fix
d3ff7f7 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
fix
6a5cae3 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
nit
4d6fa45 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
nit
d3b732c 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta merged commit 3f64500 into master Nov 4, 2024
12 checks passed
@igorDykhta igorDykhta deleted the igr/fix-overriding-experimental-props branch November 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@ilyabo ilyabo Awaiting requested review from ilyabo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorDykhta @ibgreen