Refactor image and video classes to support parallel and order flag #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parallel and ordered processing
|
what if I wanted to name frames by their actual id in the sequence instead of [0, N-1]? |
what is actual id in the sequence? the index of frame in the video chunk frame sequence? |
Assuming a video with M frames numbered from 0 to M - 1, I want extracted frames to keep their number. for example, if M = 50, N = 5 (number of frames to extract). the extracted frames can be [0,17,20,33,49] instead of [0,1,2,3,4]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow katna to output pictures in chronological order, I added two flags, parallel and ordered, to katna's code and passed them in when creating the video. If set parallel to False and set ordered to True, the output keyframes will be ordered.