feat(metrics-operator): support Cortex metrics provider #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
odubajDT
commented
Mar 27, 2024
bacherfl
reviewed
Mar 27, 2024
bacherfl
previously approved these changes
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
==========================================
+ Coverage 85.29% 85.33% +0.04%
==========================================
Files 167 167
Lines 7412 7412
==========================================
+ Hits 6322 6325 +3
+ Misses 801 799 -2
+ Partials 289 288 -1
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
previously approved these changes
Mar 29, 2024
RealAnna
reviewed
Apr 2, 2024
odubajDT
force-pushed
the
feat/2903/cortex
branch
from
6ec9d34
to
ea5e521
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
feat/2903/cortex
branch
from
ea5e521
to
6c6c70d
Compare
RealAnna
approved these changes
Apr 2, 2024
|
bacherfl
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2903
Prometheus and Cortrex metrics providers have 100% compatible API, see here
metrics provider uses only single api endpoint, which is same for Cortex as well, see here