Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): support Cortex metrics provider #3361

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 27, 2024

Fixes: #2903

Prometheus and Cortrex metrics providers have 100% compatible API, see here

metrics provider uses only single api endpoint, which is same for Cortex as well, see here

@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator labels Mar 27, 2024
@odubajDT odubajDT marked this pull request as ready for review March 27, 2024 14:08
@odubajDT odubajDT requested review from a team as code owners March 27, 2024 14:08
bacherfl
bacherfl previously approved these changes Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (a41001d) to head (6c6c70d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
+ Coverage   85.29%   85.33%   +0.04%     
==========================================
  Files         167      167              
  Lines        7412     7412              
==========================================
+ Hits         6322     6325       +3     
+ Misses        801      799       -2     
+ Partials      289      288       -1     
Files Coverage Δ
...rics-operator/api/v1/keptnmetricsprovider_types.go 66.66% <ø> (ø)
...-operator/controllers/common/providers/provider.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.04% <ø> (+0.24%) ⬆️
lifecycle-operator 83.46% <ø> (ø)
metrics-operator 88.32% <100.00%> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl
bacherfl previously approved these changes Mar 29, 2024
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 8f0c9ca into keptn:main Apr 2, 2024
47 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Cortex metrics provider in Keptn Metrics Operator
3 participants