Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace reference to version with revision in App CRDRef #3312

Merged
merged 6 commits into from
Mar 20, 2024
Merged

docs: replace reference to version with revision in App CRDRef #3312

merged 6 commits into from
Mar 20, 2024

Conversation

RealAnna
Copy link
Contributor

This pr removes inexact information in our reference docs.

@RealAnna RealAnna requested review from a team as code owners March 20, 2024 13:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 20, 2024
mowies
mowies reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add a line about the version now being a hash?

docs/docs/reference/crd-reference/app.md Outdated Show resolved Hide resolved
@RealAnna @mowies
Update docs/docs/reference/crd-reference/app.md
5e86aa3 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 08680f8 into main Mar 20, 2024
11 checks passed
@odubajDT odubajDT deleted the docs/fix-worng-info branch March 20, 2024 14:29
@keptn-bot keptn-bot mentioned this pull request Mar 20, 2024
Merged
@mowies mowies mentioned this pull request Mar 21, 2024
Closed
@mowies mowies linked an issue Mar 21, 2024 that may be closed by this pull request
fix keptnapp version difference #3311
Closed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@RealAnna @mowies @Vickysomtee
docs: replace reference to version with revision in App CRDRef (keptn…
a5ed475 
…#3312)

Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix keptnapp version difference
3 participants
@RealAnna @mowies @odubajDT