Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce v1 API version #3344

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 25, 2024

Changes

  • introduce new v1 API custom resources
  • adapt README badge
  • adapt helm charts
  • re-generate documentation
  • re-generate helm tests
  • introduce conversion webhooks

Fixes: #3234

@github-actions github-actions bot added documentation Improvements or additions to documentation ops lifecycle-operator labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 97.45493% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 88.02%. Comparing base (7874208) to head (8b68c00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3344      +/-   ##
==========================================
+ Coverage   87.05%   88.02%   +0.96%     
==========================================
  Files         162      176      +14     
  Lines        8665     9608     +943     
==========================================
+ Hits         7543     8457     +914     
- Misses        831      856      +25     
- Partials      291      295       +4     
Files Coverage Δ
...ecycle-operator/apis/lifecycle/v1/common/common.go 100.00% <100.00%> (ø)
...ecycle-operator/apis/lifecycle/v1/common/phases.go 100.00% <100.00%> (ø)
...-operator/apis/lifecycle/v1/keptnapp_conversion.go 100.00% <100.00%> (ø)
...perator/apis/lifecycle/v1/keptnappcontext_types.go 100.00% <100.00%> (ø)
...or/apis/lifecycle/v1/keptnappversion_conversion.go 100.00% <100.00%> (ø)
...is/lifecycle/v1/keptnevaluationdefinition_types.go 100.00% <100.00%> (ø)
...or/apis/lifecycle/v1beta1/keptnappcontext_types.go 100.00% <ø> (ø)
...cycle-operator/apis/lifecycle/v1/keptnapp_types.go 92.30% <92.30%> (ø)
...apis/lifecycle/v1/keptnappcreationrequest_types.go 77.77% <77.77%> (ø)
...perator/apis/lifecycle/v1/keptnevaluation_types.go 96.82% <96.82%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 57.79% <ø> (-0.98%) ⬇️
lifecycle-operator 88.08% <97.45%> (+1.58%) ⬆️
metrics-operator 88.32% <ø> (ø)
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 25, 2024 14:25
@odubajDT odubajDT requested review from a team as code owners March 25, 2024 14:25
Signed-off-by: odubajDT <[email protected]>
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit 1d851c5 into main Mar 26, 2024
48 checks passed
@odubajDT odubajDT deleted the feat/3234/api branch March 26, 2024 07:43
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create API, adapt readme, re-generate API docs, update helm chart
3 participants