Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add blog post about using Keptn within Argo Workflows #3487

Merged
merged 6 commits into from
May 14, 2024
Merged

docs: add blog post about using Keptn within Argo Workflows #3487

merged 6 commits into from
May 14, 2024

Conversation

bacherfl
Copy link
Member

Closes #3397

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
@bacherfl
fix linting and spelling
5777ffc 
Signed-off-by: Florian Bacher <[email protected]>
@github-actions github-actions bot added the ops label Apr 30, 2024
@bacherfl
fix linting
20a2cfc 
Signed-off-by: Florian Bacher <[email protected]>
StackScribe
StackScribe reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this! Very nice structure with clear explanations. I would like to see the AnalysisDefinition introduce the more advanced capabilities of the Analysis feature, just to whet the reader's interest in this very powerful feature.

A few wordsmithing nits, of course. And do you know why readthedocs is apparently not rendering this blog?

docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Outdated Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Show resolved Hide resolved
docs/blog/posts/using-keptn-analyses-in-argo-workflows.md Show resolved Hide resolved
@bacherfl @StackScribe
Apply suggestions from code review
28552a4 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
Copy link
Member Author

I do like this! Very nice structure with clear explanations. I would like to see the AnalysisDefinition introduce the more advanced capabilities of the Analysis feature, just to whet the reader's interest in this very powerful feature.

A few wordsmithing nits, of course. And do you know why readthedocs is apparently not rendering this blog?

thanks for the review and suggestions! I just checked the preview again and it seems like it does show up now

@bacherfl bacherfl marked this pull request as ready for review May 13, 2024 07:41
@bacherfl bacherfl requested review from a team as code owners May 13, 2024 07:41
StackScribe
StackScribe previously approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving as is. If we want to enforce using CRD names as adjectives not nouns, I'll go through and do suggestions for that.

@bacherfl @odubajDT
Apply suggestions from code review
cb9e1e4 
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

odubajDT
odubajDT approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bacherfl bacherfl merged commit 6434efc into keptn:main May 14, 2024
11 checks passed
@keptn-bot keptn-bot mentioned this pull request May 14, 2024
Merged
@bacherfl bacherfl mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@StackScribe StackScribe StackScribe approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write blogpost on how to use Analysis feature for load tests
3 participants
@bacherfl @StackScribe @odubajDT