Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keras_core.operations.Repeat op's compute_output_spec method #380

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix keras_core.operations.Repeat op's compute_output_spec method #380

merged 1 commit into from
Jun 21, 2023

Conversation

tirthasheshpatel
Copy link
Contributor

@tirthasheshpatel tirthasheshpatel commented Jun 20, 2023 •
edited
Loading

The Repeat operation failed when there was None in the repeating axis. This PR fixes the bug and adds a test for it.

cc @ianstenbit

fchollet
fchollet approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fchollet fchollet merged commit 4c435b2 into main Jun 21, 2023
5 checks passed
@tirthasheshpatel tirthasheshpatel deleted the fix-repeats branch June 21, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirthasheshpatel @fchollet