[WIP] Implements map_coordinates op in keras-core #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Aug 23, 2023
| if len(coordinates) != input_arr.ndim: | ||
| raise ValueError( | ||
| "coordinates must be a sequence of length input.ndim, but " | ||
| "{} != {}".format(len(coordinates), input_arr.ndim) |
There was a problem hiding this comment.
Always use f-strings rather than .format()
|
|
||
| @keras_core_export("keras_core.ops.image.map_coordinates") | ||
| def map_coordinates( | ||
| input, coordinates, order, mode="constant", cval=0.0 |
There was a problem hiding this comment.
The argument names should be consistent with the APIs we already have (like affine_transform), e.g. cval should be something like fill_value
| ): | ||
| """Applies the image(s) onto a set of coordinates. | ||
|
|
||
| Args: |
| (1, "reflect"), | ||
| ] | ||
| ) | ||
| def test_map_coordinates01(self, order, mode): |
There was a problem hiding this comment.
We likely need some more test coverage
|
Considering the PR is abandoned -- will set this as an "request for contributions" item. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the map_coordinates op as described in #477 .