Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
keras_core/legacy
from coverage metrics since this module there for BC reasonskeras_core
will have higher coverage thankeras_core-jax
), so this flag should be used to track trends rather than impose thresholds.coverage
andpytest
configuration fromsetup.cfg
topyproject.toml
to keep all project configs in toml vs cfg (unfortuantelyflake8
configs need to stay insetup.cfg
since flake8 doesn't supportpyproject.toml
yet: pyproject.toml (PEP 518) support PyCQA/flake8#234)fail_ci_if_error: true
to codecov upload steps to fail the CI (and force the author to retry the workflow) on transient codecov upload failures of the formCODECOV_TOKEN
(see "Unable to locate build via Github Actions API" for the public repository codecov/feedback#126). We could circumvent the issue by adding the token as a secret but GH secrets are not visible from forks, implying that contributors will not be able to get coverage diffs for their PRs. To allow this, the only option seems to be to hardcode the token (which seems ok since the token can be setup with limited permissions) but hardcoding tokens is just sketchy...