Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/datasets] Standardise docstring usage of "Default to" #17955

Merged

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

@gbaned gbaned requested a review from qlzh727 April 13, 2023 05:48
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
keras/datasets/imdb.py Outdated Show resolved Hide resolved
keras/datasets/reuters.py Show resolved Hide resolved
keras/datasets/reuters.py Show resolved Hide resolved
@gbaned
Copy link
Collaborator

gbaned commented Apr 21, 2023

Hi @SamuelMarks Can you please resolve conflicts? Thank you!

@gbaned gbaned added stat:awaiting response from contributor and removed keras-team-review-pending Pending review by a Keras team member. labels Apr 21, 2023
# Conflicts:
#	keras/datasets/imdb.py
#	keras/datasets/reuters.py
@SamuelMarks
Copy link
Contributor Author

@gbaned Fixed

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 24, 2023
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error.

@SamuelMarks
Copy link
Contributor Author

Fixed

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Apr 25, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 25, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 26, 2023
Imported from GitHub PR #17955

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
5f176b1 by Samuel Marks <[email protected]>:

[keras/datasets/imdb.py,keras/datasets/reuters.py] Standardise docstring usage of "Default to"

--
6d271fd by Samuel Marks <[email protected]>:

[keras/datasets/reuters.py] Use backticks for defaults in docstrings

--
7ff7ccc by Samuel Marks <[email protected]>:

[keras/datasets/reuters.py] Resolve E501

Merging this change closes #17955

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17955 from SamuelMarks:keras.datasets-defaults-to 7ff7ccc
PiperOrigin-RevId: 527302425
@copybara-service copybara-service bot merged commit a64d0b7 into keras-team:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants