Adding erf function #18476
Merged
Adding erf function #18476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Sep 22, 2023
keras/ops/math_test.py
Outdated
| [-3.0, -2.0, -1.0, 0.0, 1.0, 2.0, 3.0], dtype=dtype | ||
| ) | ||
| expected_output = (2 / np.sqrt(np.pi)) * np.vectorize(math.erf)( | ||
| sample_values |
There was a problem hiding this comment.
You can just use scipy.special.erf(x) as the reference.
There was a problem hiding this comment.
Implemented it but still the checks are failing. Kindly let me know if you want me to do some extra checks, so I can rigorously test and find the reasons behind these failures. The difference seems to be the same as in the previous repository (keras-core) errors.
@keras_export("keras_core.ops.erf") corrected to @keras_export("keras.ops.erf")
fchollet
approved these changes
Sep 23, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request (clone of PR ) is raised to add the ERF function implementation along with support for various backends.
Thanks & Regards