Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the setup.py by adding classifiers and removed redundant line of code #20265

Closed
wants to merge 2 commits into from

Conversation

anirudh-hegde
Copy link

Updated the setup.py by adding classifiers and removed redundant line of code

image

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (6d569e4) to head (3aa18dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20265   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files         505      505           
  Lines       48005    48005           
  Branches     8839     8839           
=======================================
  Hits        37906    37906           
  Misses       8294     8294           
  Partials     1805     1805           
Flag Coverage Δ
keras 78.82% <ø> (ø)
keras-jax 62.23% <ø> (ø)
keras-numpy 57.37% <ø> (+<0.01%) ⬆️
keras-tensorflow 63.62% <ø> (ø)
keras-torch 62.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -44,18 +44,25 @@ def get_version(rel_path):
"optree",
"ml-dtypes",
"packaging",
"torch",
"tensorflow"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not install backend frameworks by default.

@fchollet fchollet closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants