Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a setter for layers in Sequential and Functional. #20275

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

hertschuh
Copy link
Collaborator

The Model class has a setter for layers to provide a more descriptive message on why this property cannot be changed. But it only applies to sub-class models as classes that override layers don't inherit it.

This adds a similar message for functional and sequential models.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (9dbbc72) to head (d69e229).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20275   +/-   ##
=======================================
  Coverage   78.91%   78.92%           
=======================================
  Files         509      509           
  Lines       48277    48283    +6     
  Branches     8883     8883           
=======================================
+ Hits        38099    38106    +7     
+ Misses       8345     8344    -1     
  Partials     1833     1833           
Flag Coverage Δ
keras 78.78% <100.00%> (+<0.01%) ⬆️
keras-jax 62.29% <100.00%> (+<0.01%) ⬆️
keras-numpy 57.43% <83.33%> (+<0.01%) ⬆️
keras-tensorflow 63.64% <100.00%> (+<0.01%) ⬆️
keras-torch 62.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The `Model` class has a setter for `layers` to provide a more descriptive message on why this property cannot be changed. But it only applies to sub-class models as classes that override `layers` don't inherit it.

This adds a similar message for functional and sequential models.
@fchollet fchollet merged commit bae21ac into keras-team:master Sep 21, 2024
5 of 6 checks passed
@hertschuh hertschuh deleted the layers_setter branch September 21, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants