feat: add TOTP MFA functions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexCuse
commented
Nov 23, 2023
•
AlexCuse
commented
- add OTP related arguments to login / session token login
- add new functions for OTP related server calls
- document new functions and note server version required
|
@cainlevy I think this should be good to go - I am not including the AMR claim on the JS side since we aren't in great shape to verify. Seems similar to what we did with the session ID and some of the other custom claims. |
cainlevy
approved these changes
Dec 15, 2023
|
This has some tests that should be failing (otp needs to be string | undefined). Not sure why CI came up clean. Going to try and add tests over the next week and a half or so. |
|
@cainlevy mind another look at this? I got down a bit of a rabbit hole trying to update MSW and ran into issues trying to use typescript dependencies with jest. Decided to give up and came back to fix the credentials type and add some tests using the old version. |
cainlevy
approved these changes
Jan 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.