revert oauth to frontend + upgrade 0.71.0 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Revert OAuth to Frontend + Upgrade to 0.71.0
Motivation and Context:
This pull request aims to address the integration of OAuth2 authentication specifically for the frontend, while also upgrading the chart version to 0.71.0. The motivation behind these changes is to improve the security and user experience by ensuring that OAuth2 authentication is correctly configured for the frontend portion of the application, rather than the backend. Additionally, upgrading to version 0.71.0 ensures that we are keeping up with the latest improvements and fixes in the chart.
Changes:
Chart Version Upgrade:
charts/hub/Chart.yaml.OAuth2 Proxy Configuration:
hub-api) ingress incharts/hub/templates/kerberos-hub/hub-api.yaml.hub-frontend) ingress incharts/hub/templates/kerberos-hub/hub-frontend.yaml.By moving the OAuth2 proxy configuration to the frontend, we ensure that user authentication is handled appropriately at the entry point where user interaction occurs. This not only enhances security but also aligns with best practices for managing authentication flows.
Overall, these changes contribute to a more secure and robust deployment, ensuring that the user authentication process is correctly managed and that we are utilizing the latest updates available in the chart.