Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: add schedule points in batch ops #33

Closed
wants to merge 2 commits into from
Closed

bpf: add schedule points in batch ops #33

wants to merge 2 commits into from

Commits on Feb 17, 2022

  1. adding ci files

    Nobody committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    654f866 View commit details
    Browse the repository at this point in the history

  2. bpf: add schedule points in batch ops 

    syzbot reported various soft lockups caused by bpf batch operations.

 INFO: task kworker/1:1:27 blocked for more than 140 seconds.
 INFO: task hung in rcu_barrier

Nothing prevents batch ops to process huge amount of data,
we need to add schedule points in them.

Note that maybe_wait_bpf_programs(map) calls from
generic_map_delete_batch() can be factorized by moving
the call after the loop.

This will be done later in -next tree once we get this fix merged,
unless there is strong opinion doing this optimization sooner.

Fixes: aa2e93b ("bpf: Add generic support for update and delete batch ops")
Fixes: cb4d03a ("bpf: Add generic support for lookup batch op")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Brian Vazquez <[email protected]>
Cc: Stanislav Fomichev <[email protected]>
Reported-by: syzbot <[email protected]>
    Eric Dumazet authored and Nobody committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    0e99c40 View commit details
    Browse the repository at this point in the history