Put config dicts #806
Merged
Put config dicts #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
put-config-dicts
branch
3 times, most recently
from
aa50535
to
174b057
Compare
wkz
approved these changes
Nov 6, 2024
Comment on lines
51
to
52
| "ietf-interfaces": | ||
| { |
There was a problem hiding this comment.
Suggested change
| "ietf-interfaces": | |
| { | |
| "ietf-interfaces": { |
...then remove lots of superfluous indentation below
Add all configuration in one command. Also update the test igmp_vlan to use put_config_dicts instead of put_config_dict
mattiaswal
force-pushed
the
put-config-dicts
branch
from
174b057
to
5079691
Compare
This is to workaround #807. To test automatic router id selection a new test is required, which sets interfaces and activate ospf in separete NETCONF/RESTCONF query.
This to make the test to be more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #804 and stabalize ospf_multiarea and ospf_bfd
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: