fix: re-enable chast server example tests

- fixes denoland#4108
keroxp · Mar 22, 2020 · 3780e04 · 3780e04
1 parent 12ff78e
commit 3780e04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/std/examples/chat/server_test.ts b/std/examples/chat/server_test.ts
@@ -8,7 +8,7 @@ import { delay } from "../../util/async.ts";
 
 const port = randomPort();
 
-const { test, build } = Deno;
+const { test } = Deno;
 
 async function startServer(): Promise<Deno.Process> {
   const server = Deno.run({
@@ -35,11 +35,7 @@ async function startServer(): Promise<Deno.Process> {
   return server;
 }
 
-// TODO: https://github.com/denoland/deno/issues/4108
-const ignore = build.os == "win";
-
 test({
-  ignore,
   name: "GET / should serve html",
   async fn() {
     const server = await startServer();
@@ -58,7 +54,6 @@ test({
 });
 
 test({
-  ignore,
   name: "GET /ws should upgrade conn to ws",
   async fn() {
     const server = await startServer();

diff --git a/std/http/server_test.ts b/std/http/server_test.ts
@@ -473,10 +473,10 @@ test({
         await req.respond({ body: new TextEncoder().encode(req.url) });
       }
     }
-
-    const server = serve(":8123");
+    const port = randomPort();
+    const server = serve({ port });
     const p = iteratorReq(server);
-    const conn = await Deno.connect({ hostname: "127.0.0.1", port: 8123 });
+    const conn = await Deno.connect({ hostname: "127.0.0.1", port });
     await Deno.writeAll(
       conn,
       new TextEncoder().encode("GET /hello HTTP/1.1\r\n\r\n")