Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom data for external references #760

Closed
schmunk42 opened this issue May 6, 2019 · 6 comments · Fixed by #871
Closed

Custom data for external references #760

schmunk42 opened this issue May 6, 2019 · 6 comments · Fixed by #871
Milestone

Comments

@schmunk42
Copy link

Is your feature request related to a problem? Please describe.
My use-case is to track IDs of external systems to identify eg. projects, customers, etc...

Describe the solution you'd like
I'd like to have a possiblity to add custom data to a record, eg. as JSON.

Describe alternatives you've considered
Saving it in the comments 🙊

Additional context
Continued from #683 (comment)

@kevinpapst
Copy link
Member

Interested in contributing a PR?

@schmunk42
Copy link
Author

Can't really promise it, since I have no experience with the underlying software.

But some technical questions, about how to proceed:

  • generate migration (db-changes) to add a custom_data field
  • create a CustomDataTrait
  • update forms, API

Would this be the way to go?

@kevinpapst
Copy link
Member

kevinpapst commented May 6, 2019

Yes + unit / system tests.
If you start with a draft for the Trait and the entities I can jump in and we work together on the branch. The API is a bit tricky if you don't know the libs.
The migration is fairly easy, you can use the code from last one where I added the color field to the customer/projects/activities entities.

@kevinpapst
Copy link
Member

ping @schmunk42 ready for testing #871

@kevinpapst kevinpapst added this to the 1.0 milestone Jun 20, 2019
@schmunk42
Copy link
Author

Thank you for the ping. I am quite busy atm, but will report, when I find time to test this.
Was looking good on first sight.

@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants