Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields for timesheets, customers, projects and activities #871

Merged
merged 31 commits into from
Jun 25, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 19, 2019

Description

Adds new tables and methods to define custom fields for:

  • timsheets
  • customer
  • project
  • activity

These fields are internally available and will be exported (if configured as public visible):

  • via API
  • via spreadsheet export
  • via html export
  • via (custom) invoice templates

Fixes #760
Fixes #697
Related to #497

These fields can be attached via EventListener, see documentation.

I am planning to build a plugin, which allows to configure the custom fields via UI.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.0 milestone Jun 19, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #871 into master will increase coverage by 0.07%.
The diff coverage is 96.73%.

@@             Coverage Diff              @@
##             master     #871      +/-   ##
============================================
+ Coverage     94.29%   94.36%   +0.07%     
- Complexity     2453     2570     +117     
============================================
  Files           262      277      +15     
  Lines          7724     8016     +292     
============================================
+ Hits           7283     7564     +281     
- Misses          441      452      +11
Impacted Files Coverage Δ Complexity Δ
src/Event/UserPreferenceEvent.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Event/PrepareUserEvent.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Export/Renderer/PDFRenderer.php 100% <ø> (ø) 5 <0> (ø) ⬇️
src/Event/SystemConfigurationEvent.php 57.14% <ø> (ø) 3 <0> (ø) ⬇️
src/Event/ThemeEvent.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/Event/ConfigureMainMenuEvent.php 84.61% <ø> (ø) 5 <0> (ø) ⬇️
src/DependencyInjection/Configuration.php 98.72% <ø> (-0.02%) 22 <0> (ø)
src/Export/Renderer/XlsxRenderer.php 94.11% <ø> (ø) 7 <0> (ø) ⬇️
src/Event/DashboardEvent.php 100% <ø> (ø) 4 <0> (ø) ⬇️
src/Export/Renderer/CsvRenderer.php 94.11% <ø> (ø) 7 <0> (ø) ⬇️
... and 57 more

@delcroip
Copy link

Thank you

I will check it out in July and get back to you
I still think Kimai is advanced and therefore it will interest people to have the import possibility starting with @isamuse2

br

@kevinpapst kevinpapst merged commit d8621f0 into master Jun 25, 2019
@kevinpapst kevinpapst deleted the location branch June 25, 2019 22:39
@delcroip
Copy link

delcroip commented Aug 8, 2019

hello,

I cannot find how to activate those fiedls on master; did I miss something ? or is it the paid module https://www.kimai.org/store/custom-fields-bundle.html

br

@kevinpapst
Copy link
Member Author

Either that or programmatically: https://www.kimai.org/documentation/meta-fields.html

@lock
Copy link

lock bot commented Oct 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom data for external references Add custom fields in timesheet record
2 participants