Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default_begin in duration only mode #873

Merged
merged 1 commit into from
Jun 19, 2019
Merged

use default_begin in duration only mode #873

merged 1 commit into from
Jun 19, 2019

Conversation

kevinpapst
Copy link
Member

Description

extending #859 the duration_only mode now uses the default_begin (defaults to now, so behaviour doesn't change)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.0 milestone Jun 19, 2019
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #873 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #873      +/-   ##
============================================
+ Coverage     94.23%   94.23%   +<.01%     
- Complexity     2436     2438       +2     
============================================
  Files           259      259              
  Lines          7644     7649       +5     
============================================
+ Hits           7203     7208       +5     
  Misses          441      441
Impacted Files Coverage Δ Complexity Δ
src/Timesheet/TrackingMode/DurationOnlyMode.php 100% <100%> (ø) 8 <2> (+2) ⬆️

@kevinpapst kevinpapst merged commit bdd05a2 into master Jun 19, 2019
@kevinpapst kevinpapst deleted the defaultbegin branch June 19, 2019 23:38
@lock
Copy link

lock bot commented Aug 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant