Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracking mode (duration + fixed start time) #859

Merged
merged 14 commits into from
Jun 15, 2019
Merged

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 15, 2019

Description

  • refactored tracking modes, to be real configurable objects
  • added tracking mode duration_fixed_start
    • only allows to enter a duration
    • the begin time is configurable and cannot be overwritten by the user
    • hiding start and end time columns in the user timesheet
  • added new config default_begin (default: now)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.0 milestone Jun 15, 2019
@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #859 into master will decrease coverage by 0.04%.
The diff coverage is 93.58%.

@@             Coverage Diff              @@
##             master     #859      +/-   ##
============================================
- Coverage      94.2%   94.16%   -0.05%     
- Complexity     2397     2437      +40     
============================================
  Files           254      259       +5     
  Lines          7530     7644     +114     
============================================
+ Hits           7094     7198     +104     
- Misses          436      446      +10
Impacted Files Coverage Δ Complexity Δ
src/Timesheet/TrackingMode/DefaultMode.php 100% <100%> (ø) 6 <6> (?)
src/Timesheet/TrackingMode/DurationOnlyMode.php 100% <100%> (ø) 6 <6> (?)
src/Timesheet/TrackingMode/PunchInOutMode.php 100% <100%> (ø) 7 <7> (?)
src/Controller/SystemConfigurationController.php 97.81% <100%> (ø) 17 <0> (ø) ⬇️
src/Timesheet/TrackingModeService.php 100% <100%> (ø) 5 <5> (?)
src/Form/Type/TrackingModeType.php 100% <100%> (ø) 4 <1> (?)
src/Timesheet/UserDateTimeFactory.php 100% <100%> (ø) 9 <4> (ø) ⬇️
src/Form/TimesheetAdminEditForm.php 100% <100%> (ø) 2 <1> (ø) ⬇️
src/Controller/TimesheetAbstractController.php 91.54% <100%> (-0.28%) 38 <8> (-8)
src/API/TimesheetController.php 95.63% <100%> (+0.15%) 61 <2> (+1) ⬆️
... and 14 more

@kevinpapst kevinpapst merged commit 59d2946 into master Jun 15, 2019
@kevinpapst kevinpapst deleted the tracking-mode branch June 15, 2019 21:04
@lock
Copy link

lock bot commented Aug 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant