Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of fixes for a bunch of tests #1964

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

josh-feather
Copy link
Contributor

In collaboration with @tbeadle.

  • Fix file order precedence in Config load. Previously files in the CUCKOO_ROOT conf.d directories would be loaded after files in the CUSTOM_CONF_DIR directory. Let me know if this was intentional and I'll update the PR.
    • As part of this, introduce a env var to allow tests to skip loading of custom configs. This should, hopefully, make testing more consistent across the board.
  • Flush the Error table on database test setup to prevent consecutive runs resulting in test failures.
  • Make tests use the default config files unless otherwise required.
  • Add additional skip criteria for file_extra_info tests. Some of the samples aren't in the tests/data submodule, so they failed if it was present locally.
  • Move the Config() load out of file_extra_info_modules/__init__ into the file_extra_info_modules/__init__::extractor_ctx function so config isn't loaded prematurely. This gives us the opportunity to manipulate the config that is used in the tests.

@doomedraven doomedraven merged commit b47a146 into kevoreilly:master Feb 15, 2024
3 checks passed
@josh-feather josh-feather deleted the test-improvements branch February 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants