fix (missing) margin collapses for sections #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both h2 and h3 have a margin-top set, but this rule for removing/collapsing the margin was only defined for h2. I'm assuming this was just forgotten.
✅ Deploy Preview for simplecss-cdn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes margin collapse for adjacent sections. I used a separate
section+sectionselector because I don't thinksection:first-childshould have no top margin.Also collapse the margin h3 tags at the start of a section or article. There was already an equivalent rule for h2 so it looked to me like it was forgotten.