Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in latest patch #77

Open
shahar-h opened this issue May 1, 2020 · 0 comments
Open

Performance regression in latest patch #77

shahar-h opened this issue May 1, 2020 · 0 comments

Comments

@shahar-h
Copy link

shahar-h commented May 1, 2020

Latest patch (4.2.1) has a performance regression.
I created a sample repository that demonstrates the issue.
I created 4 zip archives with empty files: 100, 1k, 5k, and 10k files.
I decompressed each one of the files and measured decompress times.

Here are the results:

  • 4.2.1:
    Decompressing 100_files.zip took 311.634899020195 milliseconds.
    Decompressing 1k_files.zip took 2147.499899983406 milliseconds.
    Decompressing 5k_files.zip took 10381.333901017904 milliseconds.
    Decompressing 10k_files.zip took 31341.986799001694 milliseconds.

  • 4.2.0:
    Decompressing 100_files.zip took 196.21060001850128 milliseconds.
    Decompressing 1k_files.zip took 1042.0124000012875 milliseconds.
    Decompressing 5k_files.zip took 4601.827601015568 milliseconds.
    Decompressing 10k_files.zip took 15453.908199995756 milliseconds.

In order to run the sample:

  • clone repo
  • cd 4.2.0 && npm install && npm start
  • cd 4.2.1 && npm install && npm start
amiramw added a commit to eclipse-theia/theia that referenced this issue May 1, 2020
decompress 4.2.1 will cause a huge performance degradation in plugins deployment
See: kevva/decompress#77

Signed-off-by: Amiram Wingarten <[email protected]>
amiramw added a commit to eclipse-theia/theia that referenced this issue May 1, 2020
decompress 4.2.1 will cause a huge performance degradation in plugins deployment
See: kevva/decompress#77

Signed-off-by: Amiram Wingarten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant