Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install edm4hep.yaml to CMAKE_INSTALL_DATADIR/edm4hep #164

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Jul 29, 2022

This installs the original yaml file to CMAKE_INSTALL_DATADIR/edm4hep` for use by data models that extend EDM4hep. This DATADIR is exposed to downstream packages as EDM4HEP_DATA_DIR, and can be used as follows:

find_package(EDM4HEP REQUIRED)
PODIO_GENERATE_DATAMODEL(eicd eic_data.yaml headers sources
  UPSTREAM_EDM edm4hep:${EDM4HEP_DATA_DIR}/edm4hep.yaml
  OUTPUT_FOLDER ${CMAKE_CURRENT_BINARY_DIR}
  )

The Gnu standard targets indicate that DATADIR is the "directory for installing idiosyncratic read-only architecture-independent data files" and "you should install your data in a subdirectory" (which seems to be suggest as lower case).

BEGINRELEASENOTES

  • Install edm4hep.yaml to CMAKE_INSTALL_DATADIR/edm4hep. The EDM4HEP_DATA_DIR cmake variable points to this directory when using edm4hep via find_package(EDM4HEP).

ENDRELEASENOTES

This installs the original yaml file to CMAKE_INSTALL_DATADIR for use by
data models that [extend
EDM4hep](AIDASoft/podio#317). This DATADIR is
exposed to downstream packages as EDM4HEP_DATA_DIR, and can be used as
follows:
```
find_package(EDM4HEP REQUIRED)
PODIO_GENERATE_DATAMODEL(eicd eic_data.yaml headers sources
  UPSTREAM_EDM edm4hep:${EDM4HEP_DATA_DIR}/edm4hep.yaml
  OUTPUT_FOLDER ${CMAKE_CURRENT_BINARY_DIR}
  )
```
@wdconinc wdconinc changed the title feat: install edm4hep.yaml to CMAKE_INSTALL_DATADIR feat: install edm4hep.yaml to CMAKE_INSTALL_DATADIR/edm4hep Jul 29, 2022
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This looks good to me and I think this can be merged, potentially after a brief discussion at tomorrows meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants