Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGeoSvc: add constantAsString accessor #142

Merged
merged 3 commits into from
Sep 12, 2023
Merged

IGeoSvc: add constantAsString accessor #142

merged 3 commits into from
Sep 12, 2023

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Aug 30, 2023 •
edited
Loading

This lets us isolate other components from a direct DD4hep dependency

BEGINRELEASENOTES

  • IGeoSvc: Add function constantAsString, to access dd4hep constants, but isolating other components from DD4hep
  • IGeoSvc: Add function getDetector as a replacement for the new deprecated lcdd function

ENDRELEASENOTES

This is part of addressing: key4hep/k4MarlinWrapper#27

@andresailer andresailer mentioned this pull request Aug 30, 2023
Merged
@andresailer andresailer merged commit 04fe026 into key4hep:main Sep 12, 2023
3 of 5 checks passed
@andresailer andresailer deleted the addAccessor branch September 12, 2023 16:44
@jmcarcell jmcarcell mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

@BrieucF BrieucF Awaiting requested review from BrieucF

@kjvbrt kjvbrt Awaiting requested review from kjvbrt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresailer @BrieucF @tmadlener