Transfer EventHeader information to LCIO event

[Zehvogel]

BEGINRELEASENOTES

• edm4hep2lcio conversion: Transfer run and event number from edm4hep EventHeader to LCIO event. Fixes Issues when running CLIC reconstruction on EDM4Hep input #110

ENDRELEASENOTES

There are still some TODOs in here where I was not sure what the best option to warn the user would be.

Depends on key4hep/k4EDM4hep2LcioConv#13

[andresailer]

nicely spotted the problem!

[tmadlener]

Should we consider moving the actual "conversion" to k4EDM4hep2LCIOConv and simply put the necessary Gaudi wrapper code in here?

[andresailer]

Should we consider moving the actual "conversion" to k4EDM4hep2LCIOConv and simply put the necessary Gaudi wrapper code in here?

Yes, you are correct, we should put the "conversion" in k4EDM4hep2LCIOConv and call it from here.

[Zehvogel]

could you specificy which part of the "conversion" I should move? Should the function in k4EDM4hep2LCIOConv return the 4 values or also set them in the LCIO event? The latter would be contrary to how the other functions are while the former seems overly complicated?

[tmadlener]

The "conversion" in this case is effectively the 4 lines of setting information in the LCEvent. The interface in k4EDM4hep2LcioConv should probably looks something like:

void setEventHeaderInfo(lcio::LCEventImpl* evt, const edm4hep::EventHeaderCollection* const evtHeaderColl);

so that the k4MarlinWrapper side of this would effectively boil down to getting the handle and passing it on.

[Zehvogel]

I made the suggested changes and also opened key4hep/k4EDM4hep2LcioConv#13

[tmadlener]

Unrelated clang-format issues should be fixed with #112

[Zehvogel]

I moved the size check + error message to this side now and got rid of the unrelated format changes

[tmadlener]

Thanks. Looks good to me. I would just like to have at least one successful build in CI before merging this.

[Zehvogel]

Can we get this merged? It builds successfully in the nightlies and I think the failing test is also failing on master and caused by #113.