Make sure to convert the CellIDEncodings for collections #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
force-pushed
the
cell-id-conversions
branch
2 times, most recently
from
e2e5c96
to
d4b41a9
Compare
|
Hi everyone, as mentioned in the key4hep/k4Clue#44, these changes work for my problem in k4clue. |
tmadlener
force-pushed
the
cell-id-conversions
branch
from
d4b41a9
to
6967471
Compare
andresailer
force-pushed
the
cell-id-conversions
branch
from
6967471
to
bb50480
Compare
andresailer
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
CellIDEncodingfor collections when going from LCIO to EDM4hep.ENDRELEASENOTES
This was missed in #120 and should have a test ideally, but that will have to come from someone else if you want them to happen before mid August.