Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only link to libraries that are actually needed #133

Closed
wants to merge 1 commit into from
Closed

Only link to libraries that are actually needed #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions k4MarlinWrapper/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ gaudi_add_module(k4MarlinWrapperPlugins
src/components/LcioEventOutput.cpp
LINK
Gaudi::GaudiAlgLib
${Marlin_LIBRARIES}
Marlin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes cmake add -lMarlin, so you would have to add -L /path/to/marlin/lib as well.

Or you make Marlin create targets.

Or you add -Wl,--as-needed
But make sure that doesn't drop libraries that we need for the EDM at runtime, but not at linktime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah forget about this PR for now, I should just close it and have to find how to solve my issues in a different way I think

)

target_include_directories(k4MarlinWrapperPlugins PUBLIC
Expand All @@ -43,7 +43,7 @@ gaudi_add_module(MarlinWrapper
LINK
Gaudi::GaudiAlgLib
k4FWCore::k4FWCore
${Marlin_LIBRARIES}
Marlin
EDM4HEP::edm4hep
)

Expand All @@ -61,8 +61,8 @@ gaudi_add_module(EDM4hep2Lcio
k4EDM4hep2LcioConv::k4EDM4hep2LcioConv
k4FWCore::k4FWCore
Gaudi::GaudiAlgLib
${LCIO_LIBRARIES}
${Marlin_LIBRARIES}
lcio
Marlin
EDM4HEP::edm4hep
)

Expand Down
2 changes: 1 addition & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ gaudi_add_module(TestE4H2L
LINK
Gaudi::GaudiAlgLib
Gaudi::GaudiKernel
${LCIO_LIBRARIES}
lcio
k4FWCore::k4FWCore
EDM4HEP::edm4hep
)
Expand Down
Loading