Skip to content

Commit

Permalink
Add a reminder to check for overlaps
Browse files Browse the repository at this point in the history
  • Loading branch information
BrieucF committed Jul 19, 2024
1 parent 7e98799 commit 83c496c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ To ease the review process, please consider the following before to open the pul
- if you added some code, is it covered by tests? See https://github.com/key4hep/k4geo/blob/main/lcgeoTests/CMakeLists.txt
- is your PR branch up to date with origin 'main'?
- are you not adding/modifying files that should not have been added/modified (or at least, not in this PR)?
- if you added/modified a detector geometry, have you checked that was no overlap? You can do so with the following command: ddsim --compactFile PATH_TO_COMPACT_FILE --runType run --ui.commandsInitialize "/geometry/test/run" >> overlapDump.txt

If your modifications are compliant with the above, populate the release note text below, and open the PR!
-->
Expand Down

0 comments on commit 83c496c

Please sign in to comment.