-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate IDEA dual-readout calorimeter geometry #292
Closed
Closed
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f45e63c
with latest dual-readout (2023-09-21) pacakge, migrated DRC geometry …
swkim95 bd28ad7
Remove cout used for debugging
swkim95 5c9075a
DRC migration code update with latest dual-readout and k4geo package …
swkim95 4c8a5be
Merge branch 'DRC_geo_migrate_230918' into DRC_geo_migrate_231113
swkim95 5280557
Merge pull request #1 from swkim95/DRC_geo_migrate_231113
swkim95 ccabc2f
remove cout for the debug
swkim95 9d25eb5
Remove duplicated DRC compact file & source codes under IDEA directory
swkim95 4ea51dc
Update DRC detetor builder to latest version
swkim95 4ebaae3
Merge branch 'main' into DRC_geo_migrate_230918
swkim95 b0bfcf9
Merge branch 'key4hep:main' into DRC_geo_migrate_230918
swkim95 0a96366
Update branch with latest k4geo & Split FiberDRC xml files
swkim95 df5d782
remove debugging cout
swkim95 d09dc81
Merge branch 'DRC_geo_migrate_230918' into PRupdate
swkim95 369d1ec
Merge pull request #2 from swkim95/PRupdate
swkim95 ccd166e
Remove unused xml files, remove IDEA directory (which does not exists…
swkim95 86941a0
Updates in IDEA XML files for implemeting Dual-readout calorimeter, D…
swkim95 ccd8dfc
Merge branch 'DRC_geo_migrate_230918' into PRupdate_240408
swkim95 ad54c67
Merge pull request #3 from swkim95/PRupdate_240408
swkim95 2c222d2
Fix xml files (remove redundant includes, remove DRC material propert…
swkim95 f5ed2f2
Update branch to latest k4geo master branch
swkim95 09107f1
Fix units in SD action plugin, add wavelength information in output file
swkim95 dccbd0a
Add Fiber DRC xml to IDEA v03
swkim95 9674154
remove debugging message, find EDM4HEP for plugins
swkim95 806a6af
Remove DRC from IDEA v02
swkim95 1a6c652
Fix indentation
swkim95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed anymore