script that compares all the files named the same within a given path #294
Conversation
(as argument). The dfiference between two files the with same name is printed out. If the files are identical, nothing is printed.
|
I don't see the use case for this script. I would guess most of the time you want to see which files changed between two versions so you can do a diff and you get the same information as above: even if it's more versions you can use |
|
This script is extremely useful to make sure that changes are properly documented, and that one doesn't change the content of a file without also changing its version or option number. |
|
@atolosadelgado have you used this script again since this PR? If not I would just close it given that no one has asked for it. I think it is quite a niche case what it solves right now and typically one will check individual files and maybe use their diff tool of choice. |
I let @BrieucF @andresailer decide what to do with this PR (if you want me to add some other things, such as a CI test, let me know). |
|
I tend to agree with Juan, unless we decide to have a strong policy imposing that any file with the same name across different folders must have the same content (which seem unlikely), we can close the PR for me. Let's see what Andre thinks. |
|
This script is extremely useful to make sure that changes are properly documented, and that one doesn't change the content of a file without also changing its version or option number. |
|
Hi @jmcarcell @andresailer @BrieucF I have upgraded the script, and added a ctest which (I think) will run for each PR. If someone opening a PR has copypasted a XML file, changed the content but not the filename, it will make the test to fail. The check is applied only to directory FCCee. There is a list of files to be ignored, so current files with same name but different content do not make the test to fail: If you have any suggestion how to improve the situation, or if it is better to abandon it, please let me know :) |
Hi,
This PR includes a bash script that compares all the files named the same within a given path (as argument). The difference between two files the with same name is printed out. If the files are identical, nothing is printed. README files are ignored.
When I run the bash script in k4geo repo, I get the following list of files with the same name and different content: