-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version of ALLEGRO with ECAL barrel with cell corners projective in phi #332
version of ALLEGRO with ECAL barrel with cell corners projective in phi #332
Conversation
Tagging @BrieucF |
Hi @BrieucF thanks for having looked at the PR and spotted the little typo in the documentation. Is there anything else needed before merging? Thanks, Giovanni |
Hi Giovanni, yes sorry, I started to review then had to do something else. Can you add a test for this new ALLEGRO version? https://github.com/key4hep/k4geo/blob/main/lcgeoTests/CMakeLists.txt#L90-L94 |
…/k4geo into gmarchio-main-20240327
done |
downstream-build errors are unrelated The following tests FAILED: |
I just added some comments to the C++ code that builds the LAr detector to make it a bit easier to follow the steps of the G4 construction, and some comments to the corresponding xml file to clarify the meaning of the vector with the layer thicknesses |
Can you also use the v03 constructor for upstream and calibration xml's? |
Yes, when we have agreed on the rounding ;) |
Ha sorry, missed the last mail, taking a look |
…ments in xml of v02. In cpp of v03 add check that electrode length in xml is consistent with calo r1 r2 and inclination angle
@BrieucF : I updated also the other xml files for v03. In the xml of v02 I clarified that the dimensions are electrode lengths scaled by calo dR/L(plane). In the cpp of v03 I also added a check that the electrode plane length in the xml is consistent within 0.5 mm with that calculated from calo R1, R2 and alpha Let me check with Nicolas if he's OK with these non rounded numbers and then I think we're good to merge |
Thanks Giovanni! LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One should also use units in the CPP implementation
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp
Outdated
Show resolved
Hide resolved
Fixed in latest commit |
Hello @andresailer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else from my side.
Thanks!
Thanks Giovanni and Andre! |
BEGINRELEASENOTES
ENDRELEASENOTES