Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA Pre-shower] Adopting IDEA muon system builder for pre-shower #397

Merged
merged 12 commits into from
Oct 1, 2024

Conversation

mahmoudali2
Copy link
Contributor

BEGINRELEASENOTES

  • Generalizing the muon system builder to adopt pre-shower description, the changes include:
    • Making the variable names more general, not specific only for muon system.
    • Changing the detector side's volume thicknesses in case there is only one chambers row in the side (like the pre-shower case), and it's in general it is the case for any -almost- circular shape for the detector.
    • Disallowing the overlap rotation in case of single chamber side.
  • Overall, the changes make the builder more general to adopt different cases with different structures (polyhedron & cylinder of chambers).

ENDRELEASENOTES

@mahmoudali2
Copy link
Contributor Author

Overlap check is clean for both Pre-shower, and Muon-system.

@BrieucF BrieucF merged commit 871e893 into key4hep:main Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants