Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCal readout segmentation update #409

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

HCal readout segmentation update #409

wants to merge 12 commits into from

Conversation

Archil-AD
Copy link

@Archil-AD Archil-AD commented Nov 9, 2024 •
edited by andresailer
Loading

BEGINRELEASENOTES

  • HCalBarrel_TileCal_v03.xml and HCalEndcaps_ThreeParts_TileCal_v03.xml files have been created with new readouts: phi-theta and phi-row segmentation
  • Two new segmentation classes are created for HCal: FCCSWHCalPhiTheta_k4geo and FCCSWHCalPhiRow_k4geo
    • New segmentation classes can calculate the global positions of the cells and determine the cell neighbours for TopoClustering

ENDRELEASENOTES

andresailer
andresailer reviewed Nov 13, 2024
View reviewed changes
detectorSegmentations/src/FCCSWHCalPhiRow_k4geo.cpp Outdated Show resolved Hide resolved
detectorSegmentations/src/FCCSWHCalPhiRow_k4geo.cpp Outdated Show resolved Hide resolved
FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/HCalBarrel_TileCal_v03.xml Outdated
<readout name="HCalBarrelReadoutPhiRow">
<segmentation type="FCCSWHCalPhiRow_k4geo"
offset_z="0"
width_z="279.55*2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a unit here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it

FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/HCalEndcaps_ThreeParts_TileCal_v03.xml Outdated
<readout name="HCalEndcapReadoutPhiRow">
<segmentation type="FCCSWHCalPhiRow_k4geo"
offset_z="HCalEndcap_min_z1+(HCalEndcap_max_z1-HCalEndcap_min_z1)*0.5 HCalEndcap_min_z2+(HCalEndcap_max_z2-HCalEndcap_min_z2)*0.5 HCalEndcap_min_z3+(HCalEndcap_max_z3-HCalEndcap_min_z3)*0.5"
width_z="24.85*2 24.3*2 77.05*2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archil-AD @andresailer